Skip to content

chore(deps-dev): bump @types/jest from 29 to 30#125

Merged
li-jia-nan merged 2 commits intomasterfrom
feat-up
Sep 17, 2025
Merged

chore(deps-dev): bump @types/jest from 29 to 30#125
li-jia-nan merged 2 commits intomasterfrom
feat-up

Conversation

@li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 8, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • 杂务
    • 升级开发依赖 @types/jest 至 ^30.0.0，提升类型兼容性与编辑器提示，非运行时变更。
    • 调整依赖声明：将 "@babel/runtime" (^7.24.7) 与 "classnames" (^2.3.2) 移至顶层 dependencies 并移除重复底层声明，依赖列表重组，不影响产品功能或公开接口。

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

将 package.json 中的依赖项结构调整：将原底部的 dependencies 移到顶层（包含 @babel/runtime 与 classnames），并将 devDependencies 中的 @types/jest 从 ^29.5.2 升级到 ^30.0.0；未修改代码或其他配置。

Changes

Cohort / File(s) Summary of changes
依赖项重组与新增
package.json		 将原底部的 dependencies 区块移至文件顶层，包含 @babel/runtime: ^7.24.7 与 classnames: ^2.3.2（依赖项位置/组织发生变更）。
DevDependency 版本更新
package.json		 将 devDependencies 中的 @types/jest 从 ^29.5.2 升级为 ^30.0.0。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

dependencies

Poem

小兔轻推 package.json，依赖搬家又升级。
Babel 与 classnames 到顶层，Jest 类型升三零。
胡萝卜翻页笑盈溢，合并即刻奔草地。 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed PR 标题 "chore(deps-dev): bump @types/jest from 29 to 30" 与变更摘要一致：唯一实质性改动是 package.json 中 devDependency @types/jest 从 ^29.5.2 升级到 ^30.0.0，标题简洁且准确反映了主要变更。但注意 pr_objectives 中显示的标题 "feat: value support string[] type" 与当前变更不符，可能导致审查或记录混淆，应核对是否为元数据错误或需要拆分。
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff8a631 and ce5b7d3.

📒 Files selected for processing (1)
  • package.json (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (4a2c8a4) to head (ce5b7d3).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   80.00%   80.00%           
=======================================
  Files           6        6           
  Lines         670      670           
  Branches      162      165    +3     
=======================================
  Hits          536      536           
  Misses        134      134

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@li-jia-nan li-jia-nan requested a review from kiner-tang January 8, 2025 22:06
@li-jia-nan li-jia-nan closed this Sep 17, 2025
@li-jia-nan li-jia-nan reopened this Sep 17, 2025
@li-jia-nan li-jia-nan changed the title feat: value support string[] type chore(deps-dev): bump @types/jest from 29 to 30 Sep 17, 2025
@socket-security
Copy link

socket-security bot commented Sep 17, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​types/​jest@​29.5.14 ⏵ 30.0.01001007779100

View full report

@li-jia-nan li-jia-nan merged commit 7aafb60 into master Sep 17, 2025
7 checks passed
@li-jia-nan li-jia-nan deleted the feat-up branch September 17, 2025 20:49
coderabbitai[bot]
coderabbitai bot reviewed Sep 17, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
package.json (1)

49-49: PR 目标与改动不一致，请确认是否缺少提交

PR 标题为“feat: value support string[] type”，但当前仅调整了 @types/jest 版本。请确认是否有漏推的实现或测试代码需要一并提交，避免发布后语义与改动不符。

需要的话我可以协助把预期变更拆成两条 PR（功能与工具链升级分别提交），以降低回归风险。

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a2c8a4 and ff8a631.

📒 Files selected for processing (1)
  • package.json (1 hunks)
🔇 Additional comments (1)
package.json (1)

49-49: 对齐 @types/jest 与 ts-jest 主版本（需确认 Jest 运行时版本）

package.json devDependencies 中 @types/jest = ^30.0.0，ts-jest = ^29.1.4；jest.config.js 使用 ts-jest preset。仓库未包含 lockfile，无法确认实际安装的 Jest 主版本，存在类型不匹配风险。建议二选一对齐：

  • 方案 A（保守）：降级 @types/jest 至 29：
-    "@types/jest": "^30.0.0",
+    "@types/jest": "^29.5.2",
  • 方案 B（升级链）：将 ts-jest 升到 30 并确认底层 Jest 为 30（可能需升级 rc-test 或显式安装 jest@^30）：
-    "ts-jest": "^29.1.4",
+    "ts-jest": "^30.0.0",

在本地确认实际安装的 Jest 主版本（检查 pnpm-lock.yaml / package-lock.json / yarn.lock，或运行 npm/pnpm/yarn ls jest，或检查 rc-test 的依赖），并按上述方案对齐。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@kiner-tang kiner-tang Awaiting requested review from kiner-tang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@li-jia-nan